Improve Passing Booleans in PHP original

by Freek Van der Herten – 1 minute read

Passing booleans to a method can be code smell, as it is not clear what a boolean does by reading the calling code.

$this->getPrice(true);

A common way to improve on this is by assigning the boolean to a variable with a descriptive name.

$this->getPrice($includingTaxes = true);

Instead of using a temporary variable, you could also use PHP 8's named arguments.

$this->getPrice(includingTaxes: true);

A an even better way to solve this would be to introduce methods with a descriptive name.

class Invoice
{
    public function getPriceIncludingTax(): int
    {
        // …
    }
    
    public function getPriceExcludingTax(): int
    {
        // …
    }
}

// …


$invoice->getPriceIncludingTax();

In general, don't avoid using longer names when they clarify your code. Quality code is not about writing the least amount of words and letters, it's about writing code that can be understood and maintained for years to come.

If you want to read more tips like this one, consider picking up our course on Writing Readable PHP.

Join 9,500+ smart developers

Get my monthly newsletter with what I learn from running Spatie, building Oh Dear, and maintaining 300+ open source packages. Practical takes on Laravel, PHP, and AI that you can actually use.

"Always fresh, useful tips and articles. Carefully selected community content. My favorite newsletter, which I look forward to every time."

Bert De Swaef — Developer at Vulpo & Youtuber at Code with Burt

No spam. Unsubscribe anytime. You can also follow me on X.

Found something interesting to share? Submit a link to the community section.