Scout APM is PHP application performance monitoring designed for developers. With tracing logic that ties issues back to the line of code causing them, you can pinpoint n+1 queries, memory leaks, and other abnormalities in real time so you can knock them out and get back to building a great product. Start your free 14-day trial today and get the performance insight you need in less than 4 minutes.

The best PRs we got in October

Original – by Freek Van der Herten – 4 minute read

At Spatie, we want to stimulate contributing to our open source stuff. That's why we said that we'd give away some of our paid products for free to authors of the best PRs we got in October. In a way, it's our own small version of Hacktoberfest.

In this blog post, I'd like to announce the winners.

What makes a good PR?

Before announcing the winners, let's take a look at what we consider a good pull request.

For all PRs we highly value:

  • a good title that makes it clear what the PR is about. So not "fixing bug" or anything too general.
  • a nice description that explains the problem and solution.

If a PR adds functionality or fix bugs, we highly value:

  • that only the minimum of lines needed is changed. Sometimes people add code styling fixes according to their rules to the PR, making the changed code that matters hard to spot. Also, only fix one bug or add one functionality per PR. If there a PR with multiple unrelated changes in it, we might close it when we dislike one of those things.
  • tests for the new feature or bug fix, so we know it works correctly. In most cases, the old tests should not be touched.
  • when adding a new feature, also update the readme or docs so users know how to use the new code

Don't be afraid to PR small things. We value typo fixes as much as new functionality. We're grateful for all contributions, big and small.

The winners of our giveaway

It was hard to choose winners because we got a lot of high-quality PRs. We decided to pick three very different PRs.

1. A new file option on laravel-tail

screenshot

The first winner is Scott Carpenter for this excellent PR that adds a new option to tail a specific log in laravel-tail.

This PR is a prime example of what makes a good PR:

  • there's a nice, friendly description of what's in the PR
  • the change code follows our guidelines
  • the readme has been updated
  • tests have been added

2. Correcting a typo fix

screenshot

We don't only value new functionality, but typo fixes as well. Here's a cool PR by Donatien Schmitz that fixes a typo in our Laravel Package skeleton.

Even though the typo is in code that probably no single user would notice, we highly appreciate this fix.

3. New logos for several packages

screenshot

The third winner did something remarkable. Caneco got in touch with us and has PR'ed logos to several of our packages. We don't see this every day and are very grateful for the time he put into this.

Other very nice PRs

Here are some other really nice PRs we got in October:

In closing

Congratulations to the winners! We'll contact them soon and give them a coupon code that allows them to purchase one of our paid products for free.

Stay up to date with all things Laravel, PHP, and JavaScript.

Follow me on Twitter. I regularly tweet out programming tips, and what I myself have learned in ongoing projects.

Every two weeks I send out a newsletter containing lots of interesting stuff for the modern PHP developer.

Expect quick tips & tricks, interesting tutorials, opinions and packages. Because I work with Laravel every day there is an emphasis on that framework.

Rest assured that I will only use your email address to send you the newsletter and will not use it for any other purposes.

Comments

Webmentions

Vaggelis Yfantis liked on 5th November 2020
José Cage liked on 5th November 2020
Hardik Shah liked on 3rd November 2020
Robin Dirksen liked on 2nd November 2020
Helder Willian liked on 2nd November 2020
Alejandro Pérez liked on 2nd November 2020
PHPTrends retweeted on 2nd November 2020
Michael O'Connor liked on 2nd November 2020
Rod Elias liked on 2nd November 2020
Miguel Piedrafita 🚀 liked on 2nd November 2020
ArielMejiaDev liked on 2nd November 2020
Gianluca Bine liked on 2nd November 2020
tona.castelan liked on 2nd November 2020
Israel Araujo liked on 2nd November 2020
Vince Mitchell liked on 2nd November 2020
eraldgreca liked on 2nd November 2020
Wouter Brouwers liked on 2nd November 2020
/dev/caneco replied on 2nd November 2020
Thank you for the gift! It's gonna feel like an early Xmas. And no worry… more PRs to come in November 😇
Seba Ramírez Pastore liked on 2nd November 2020
Luigi Cruz liked on 2nd November 2020
Niels Vanpachtenbeke liked on 2nd November 2020
Samy liked on 2nd November 2020
Rogerio B Jr liked on 2nd November 2020
mubarak liked on 2nd November 2020
PHP Synopsis retweeted on 2nd November 2020
Scott Carpenter replied on 2nd November 2020
A huge thanks to @freekmurze and the amazing @spatie_be team!
Oliver Nybroe liked on 2nd November 2020
Oliver Nybroe retweeted on 2nd November 2020
Scott Carpenter liked on 2nd November 2020
Craig Potter liked on 2nd November 2020
John Braun liked on 2nd November 2020
Florian Voutzinos liked on 2nd November 2020
Saumya Sthapit liked on 2nd November 2020
#EndSars liked on 2nd November 2020
Dries Vints liked on 2nd November 2020
Zubair Mohsin liked on 2nd November 2020
Tauseef shah liked on 2nd November 2020
Hadi Swais liked on 2nd November 2020